search

cattle-ops / terraform-aws-gitlab-runner

Terraform module for AWS GitLab runners on ec2 (spot) instances
https://registry.terraform.io/modules/cattle-ops/gitlab-runner/aws
MIT License
576 stars 326 forks source link

Report an error when the ssm key doesn't exist #1139

Closed lmilbaum closed 1 month ago

lmilbaum commented 2 months ago

Describe the solution you'd like

Fail the apply if the SSM access key is not found

kayman-mk commented 1 month ago

@lmilbaum Could you please add some details? Not sure what you mean.

lmilbaum commented 1 month ago

@lmilbaum Could you please add some details? Not sure what you mean.

I forgot to setup the SSM access key before deployment. No error reported. But, the runner didn't work as expected.

kayman-mk commented 1 month ago

This one? var.runner_gitlab.preregistered_runner_token_ssm_parameter_name

lmilbaum commented 1 month ago

This one? var.runner_gitlab.preregistered_runner_token_ssm_parameter_name

The key was populated with a name but I didn't create the resource in AWS