cattle-ops / terraform-aws-gitlab-runner

Terraform module for AWS GitLab runners on ec2 (spot) instances
https://registry.terraform.io/modules/cattle-ops/gitlab-runner/aws
MIT License
587 stars 331 forks source link

fix: use existing Runner package for Amazon Linux 2023 as default #1155

Closed kayman-mk closed 4 months ago

kayman-mk commented 4 months ago

Description

Since #1138 was merged, the runner_gitlab.runner_version was wrong. The mentioned package 15.8.2 does not exist for Amazon Linux 2023. This PR updates the default version to 16.0.3 the oldest available version.

You should never rely on the default value as your Runner has to match the GitLab version. See https://docs.gitlab.com/runner/#gitlab-runner-versions

Closes #1147

Migrations required

Usually not. In case you are still on GitLab < 16 you have to use the old AMI matching amzn2-ami-hvm-2.*-x86_64-ebs (used before #1138 was merged). Then you are able to still use an older version of the Runner.

Verification

github-actions[bot] commented 4 months ago

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

github-actions[bot] commented 4 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.62s
✅ REPOSITORY checkov yes no 14.88s
✅ REPOSITORY dustilock yes no 0.27s
✅ REPOSITORY gitleaks yes no 1.3s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.29s
✅ REPOSITORY secretlint yes no 1.09s
✅ REPOSITORY syft yes no 0.45s
✅ REPOSITORY trivy-sbom yes no 1.18s
✅ REPOSITORY trufflehog yes no 3.99s
✅ SPELL cspell 2 0 2.66s
✅ TERRAFORM terraform-fmt 1 0 0 0.06s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_