cattle-ops / terraform-aws-gitlab-runner

Terraform module for AWS GitLab runners on ec2 (spot) instances
https://registry.terraform.io/modules/cattle-ops/gitlab-runner/aws
MIT License
587 stars 331 forks source link

feat: add `pre_get_sources_script` for GitLab Runner 17+ #1158

Closed kayman-mk closed 4 months ago

kayman-mk commented 4 months ago

Description

Adds the pre_get_sources_script (GitLab Runner 17+) parameter which is filled with the value of pre_clone_script (GitLab Runner < 17).

The parameter was renamed. Deprecation warnings are shown in the logs of GitLab Runner 16. GitLab Runner 17 simply ignores the parameter and therefor the whole script. This might result in failing pipelines.

Verification

github-actions[bot] commented 4 months ago

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

github-actions[bot] commented 4 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.64s
✅ REPOSITORY checkov yes no 13.87s
✅ REPOSITORY dustilock yes no 0.25s
✅ REPOSITORY gitleaks yes no 1.52s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.16s
✅ REPOSITORY secretlint yes no 0.96s
✅ REPOSITORY syft yes no 0.34s
✅ REPOSITORY trivy-sbom yes no 1.55s
✅ REPOSITORY trufflehog yes no 5.38s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_