search

cauliframework / cauli

Debug Networking
https://cauli.works
MIT License
28 stars 5 forks source link

Add support for spm #200

Closed akarsh closed 5 years ago

akarsh commented 5 years ago

This adds SPM support for the Cauli Framework.

Fixes #199

akarsh commented 5 years ago

swift build is sufficient or if we need to define the sdk and target.

it is not sufficient anymore. I saw the error from CI - https://travis-ci.org/cauliframework/cauli/builds/595614756#L1985 which is the same as I mentioned before https://github.com/cauliframework/cauli/issues/199#issuecomment-539604961 we need to add some configuration to define the target and sdk path

brototyp commented 5 years ago

swift build is sufficient or if we need to define the sdk and target.

it is not sufficient anymore. I saw the error from CI - https://travis-ci.org/cauliframework/cauli/builds/595614756#L1985 which is the same as I mentioned before #199 (comment) we need to add some configuration to define the target and sdk path

Yeah. I also had a look at it. I thought we can just set the Platform in the Package.swift like this (which we should) but that doesn't work either.

    name: "Cauliframework",
    platforms: [
        .iOS(.v8)
    ],

Do you want to try the solution you found before?

akarsh commented 5 years ago

In this commit b6f93ba I tried with my solution to the swift build it works now.

brototyp commented 5 years ago

Super awesome! Great work. What do you think about either tweaking the Package.swift to comply with the switflint rules or exclude it from being checked by swiftlint? Just so we get rid of the warnings here. I think once we got that, we can merge this.

akarsh commented 5 years ago

Super awesome! Great work. What do you think about either tweaking the Package.swift to comply with the switflint rules or exclude it from being checked by swiftlint? Just so we get rid of the warnings here. I think once we got that, we can merge this.

I added Package.swift in exclude section of swiftlint in this commit 5269f89

brototyp commented 5 years ago

Really nice. I noticed one more thing. In your ticket you wrote this:

Add a section about swift package manager (spm) in brief similar to the pods to README.md

I think that's actually a really good idea. Do you still want to do that?

akarsh commented 5 years ago

I agree with you. I was waiting for the approval to the code before adding the section to the README.md file. This commit cf7aad5 updates the README.md file.

brototyp commented 5 years ago

Really nice. Well done! Thanks for your work!

brototyp commented 5 years ago

Hey @akarsh, congratulations to your first merged pull request. Cauli is now your project too. I just invited you as a team member with write permission. We are exited to have you!

akarsh commented 5 years ago

Thank you @brototyp I am happy to be part of the project.