search

cauliframework / cauli

Debug Networking
https://cauli.works
MIT License
28 stars 5 forks source link

Fixed a bug where table get under the toolbar on scrolling in inspect… #204

Open kaynewcomer opened 4 years ago

brototyp-bot commented 4 years ago
1 Error
:no_entry_sign: Please include a CHANGELOG entry to credit yourself!
You can find it at /CHANGELOG.md.
4 Warnings
:warning: Are there any changes that should be explained in the README.md?
:warning: Cauli/Florets/Inspector/Record List/InspectorTableViewController.swift#L68 - Variable name should be between 3 and 40 characters long: ‘y’
:warning: Cauli/Florets/Inspector/Record List/InspectorTableViewController.swift#L118 - Top-level declarations should specify Access Control Level keywords explicitly.
:warning: Cauli/Florets/Inspector/Record List/InspectorTableViewController.swift#L131 - Top-level declarations should specify Access Control Level keywords explicitly.

Example CHANGELOG entry

* **feature/improvement/bugfix** Fixed a bug where table get under the toolbar on scrolling in inspect…  
  [#issue_number](https://github.com/cauliframework/cauli/issues/issue_number) by @kaynewcomer

Trivial PR?

If you think your PR is trivial and neither a CHANGELOG entry nor a README update is necessary, you can add a #trivial to your PR title. The bot will pick that up and will not warn about a missing CHANGELOG or README entry.

Generated by :no_entry_sign: Danger

thorstenstark commented 4 years ago

Any updates on this here @brototyp @pstued ?

brototyp commented 4 years ago

Thanks for the bump! It wasn't on my radar at all. I'll try to check it this weekend.

brototyp commented 4 years ago

Hi @kaynewcomer and @thorstenstark,

thanks for the PR and the involvement. Unfortunately I can't find the bug this PR is fixing. At least in the example app the development branch works fine.

Can you come up with reproduction steps, if possible things that are different in the example app, so I can reproduce them?