Dependency `selectors` is not on the last version

causal-agent / scraper

HTML parsing and querying with CSS selectors

https://docs.rs/scraper

ISC License

1.81k stars 100 forks source link

Dependency `selectors` is not on the last version #89

Closed Elrendio closed 1 year ago

Elrendio commented 1 year ago

Current version used: 0.22 Last version: 0.23

Seems like just bump the version won't make a breaking change. A good practice is also to re-export the crate selectors to avoid users having to guess which version they should be using 😊

teymour-aldridge commented 1 year ago

IIRC there were some problems upgrading selectors when we tried, but they may have disappeared. A patch would be most welcome!

cfvescovo commented 1 year ago

@teymour-aldridge you're right.

I tried updating selectors but there was a compatibility issue with css-parser.

cfvescovo commented 1 year ago

@Elrendio if you have a patch feel free to open a PR. I will happily review it.

cfvescovo commented 1 year ago

We cannot fix this right now because a refactor would be needed to update selectors. As I am not sure on what approach should be taken (we could either refactor to support the latest version of selectors or remove LocalNames completely, see #45), I set this as wontfix for now

cfvescovo commented 1 year ago

Solved in #99