An Error Type for `Selector::parse`

causal-agent / scraper

HTML parsing and querying with CSS selectors

https://docs.rs/scraper

ISC License

1.81k stars 100 forks source link

An Error Type for `Selector::parse` #95

Closed Kiwifuit closed 1 year ago

Kiwifuit commented 1 year ago

I might be adding different error types if needed, but for now the error type for Selector::parse's Result is now a custom type that is exported. This PR resolves #60 Improvements to the code are welcome

cfvescovo commented 1 year ago

LGTM even though some readability improvements would be welcome

teymour-aldridge commented 1 year ago

I think it makes sense to implement Error for this type.

Kiwifuit commented 1 year ago

I would really appreciate if this fork gets merged ASAP as I need these changes to continue working on a project

cfvescovo commented 1 year ago

Looking into this rn, will be back ASAP