Fix: DO-3172 numeric input none value is inconsistent - Githubissues

causalens / dara

Dara is a dynamic application framework designed for creating interactive web apps with ease, all in pure Python.

https://dara.causalens.com

Apache License 2.0

375 stars 9 forks source link

Fix: DO-3172 numeric input none value is inconsistent #326

Closed patricia-causalens closed 4 months ago

patricia-causalens commented 4 months ago

Motivation and Context

Issue was found when emptying a numeric input. Its value as stored in the variable was None, whereas in an action ctx.input returned NaN.

Implementation Description

We convert the value based on whether the input is numeric, however we were not passing this new value to the action

Any new dependencies Introduced

None

How Has This Been Tested?

Locally

PR Checklist:

[x] I have implemented all requirements? (see JIRA, project documentation).
[x] I am not affecting someone else's work, If I am, they are included as a reviewer.
[ ] I have added relevant tests (unit, integration or regression).
[ ] I have added comments to all the bits that are hard to follow.
[ ] I have added/updated Documentation.
[x] I have updated the appropriate changelog with a line for my changes.

Screenshots (if appropriate):