causalens / dara

Dara is a dynamic application framework designed for creating interactive web apps with ease, all in pure Python.
https://dara.causalens.com
Apache License 2.0
375 stars 9 forks source link

Improvement: DO-3640: Input and NumericInput now accept standard HTML element props #361

Closed Roman-Kornev closed 3 months ago

Roman-Kornev commented 3 months ago

Motivation and Context

Previously, Input and NumericInput did not accept standard HTML props as it doesn't extend from the InputHTMLAttributes<HTMLInputElement> interface. Now they both do, so we can remove the redundant props being passed and use all standard html props without issues.

Implementation Description

Any new dependencies Introduced

How Has This Been Tested?

Locally

PR Checklist:

Screenshots (if appropriate):

tamara-causalens commented 3 months ago

lovely! good to merge @Roman-Kornev?

Roman-Kornev commented 3 months ago

@tamara-causalens Yeah, should be good