causalincentives / pycid

Library for graphical models of decision making, based on pgmpy and networkx
Apache License 2.0
96 stars 13 forks source link

factor out CausalBayesianNetwork #46

Closed tom4everitt closed 3 years ago

tom4everitt commented 3 years ago

MACIDBase is becoming quite large, and combines two separate roles:

  1. Extend BayesianModel with queries, interventions, and capability of handling StochasticFunctionCPDs
  2. Handle influence diagram specific functions like different node types and computing optimal decision rules

It would probably be good to separate these functions into two different classes.

Basically, CausalBayesianNetwork would do:

The rest would stay in MACIDBase, which now inherits from CausalBayesianNetwork instead of pgmpy.CausalModel

Jamesfox1 commented 3 years ago

I'll do this now

Jamesfox1 commented 3 years ago

done