causefx / Organizr

HTPC/Homelab Services Organizer - Written in PHP
GNU General Public License v3.0
5.12k stars 290 forks source link

Fix hardcoded limit on new tautulli module #1341

Closed G4Zz0L1 closed 4 years ago

G4Zz0L1 commented 4 years ago

https://github.com/causefx/Organizr/blob/d2685cc64948c665279af67369e0adebf9e43164/js/functions.js#L6617

This row shoud change to:

for(var i = 0; i < Math.min(5, e['rows'].length); i++) {

When there are less than 5 users on that report, the js breaks on that for.

G4Zz0L1 commented 4 years ago

Another thing I've noticed, but I can't resolve now, it's the image url.

image

I've put organizr in a custom url (like 'myserver.com/organizr') and the image doesn't get the correct url for the thumbs. It should take /organizr/plugins/images/cache/ like the plex one does here, but instead it's /plugins/images/cache/ and I can't get it to work.

https://github.com/causefx/Organizr/blob/e9c77f50e3340d188b59756f8dab338bf230ea56/api/functions/homepage-connect-functions.php#L372 https://github.com/causefx/Organizr/blob/e9c77f50e3340d188b59756f8dab338bf230ea56/api/functions/homepage-connect-functions.php#L532

causefx commented 4 years ago

the image url should be fixed now - please test

G4Zz0L1 commented 4 years ago

Nope, it does the same thing.

image

causefx commented 4 years ago

my bad - forgot the hardcoded ones thanks!

G4Zz0L1 commented 4 years ago

Perfect, now it works! Thanks a lot!