search

causefx / Organizr

HTPC/Homelab Services Organizer - Written in PHP
GNU General Public License v3.0
4.99k stars 288 forks source link

Added iframe allow options #1970

Closed jejbq closed 4 months ago

jejbq commented 4 months ago

Hello,

Following your Patch Added iframe sandbox options, I've added another drop-down list for the iframe allow options so that users can adjust the iframe Permissions Policy via the allow attribute.

This solves my issue 1669 of including Nextcloud Talk (part of Nextcloud AIO) inside an iframe in Organizr.

Please note that I have removed allowfullscreen="true" in favor of allow="fullscreen" in buildFrame() because fullscreen is now set by default in the iframeAllow variable.

Thank you in advance for your help in merge and fixing this problem.

REFERENCES List of features for allow attribute Permissions Policy

causefx commented 4 months ago

i will look at this today and get it merged. can you change it to v2-develop plz

causefx commented 4 months ago

looks good to me!

jejbq commented 4 months ago

How can I receive notification when this has been merged into v2-master?

My local patch was overridden over the weekend (because of 'v2-master'), so I had to switch my docker to the 'v2-develop' branch.

Thank you for the pull.