search

causefx / Organizr

HTPC/Homelab Services Organizer - Written in PHP
GNU General Public License v3.0
5.01k stars 288 forks source link

V2 - Users able to request content which already exists in Plex & Ombi #892

Closed EvilTactician closed 5 years ago

EvilTactician commented 6 years ago
Organizr Version: 2.0.0-beta.200
Branch: v2-develop
WebSever: nginx/1.10.3
Operating System: 7.0.30-0ubuntu0.16.04.1
Problem Description:

Users are able to request content which already exists in Plex and show as already existing in Ombi too.

Reproduction Steps:

Search for content which doesn't exist. "hello internet" Get the "No Results for: hello internet" screen, click "Would you like to request it?" Get the "Requests" search bar this way, search for anything and request it even if it already exists. Content is added to Ombi as a Request even if it already exists.

This is just an example of how to get to the request bar, obviously there are other routes. The main point is that you can request things which exist from that version of the search bar. The "main" bar is fine and seems to check for this.

Errors on screen? If so paste here:

No errors, it works flawlessly. But it probably shouldn't :)
causefx commented 6 years ago

We can ask ombi to do a check with their api....

Sent from my iPhone

On May 28, 2018, at 1:01 AM, EvilTactician notifications@github.com wrote:

Organizr Version: 2.0.0-beta.200

Branch: v2-develop

WebSever: nginx/1.10.3

Operating System: 7.0.30-0ubuntu0.16.04.1

Problem Description:

Users are able to request content which already exists in Plex and show as already existing in Ombi too.

Reproduction Steps:

Search for content which doesn't exist. "hello internet" Get the "No Results for: hello internet" screen, click "Would you like to request it?" Get the "Requests" search bar this way, search for anything and request it even if it already exists. Content is added to Ombi as a Request even if it already exists.

This is just an example of how to get to the request bar, obviously there are other routes. The main point is that you can request things which exist from that version of the search bar. The "main" bar is fine and seems to check for this.

Errors on screen? If so paste here:

No errors, it works flawlessly. But it probably shouldn't :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

EvilTactician commented 6 years ago

That sounds like a sensible solution. Loving organizr btw, great work so far. I think it has potential to become the details facto norm for most Plex admins. My users love it as well, makes everything so convenient when ombi and tautulli are just there for them as well.

causefx commented 5 years ago

seems like it's gna stay the way it is....