search

cavalab / srbench

A living benchmark framework for symbolic regression
https://cavalab.org/srbench/
GNU General Public License v3.0
203 stars 74 forks source link

New try for rils-rols==1.5.15 #166

Closed kartelj closed 5 months ago

kartelj commented 5 months ago

I have removed certain os.environment settings from setup.py. Maybe these settings affected previous ITEA fail.

folivetti commented 5 months ago

sabotage!! 😂

Setting values to os.environment may be a reason to break itea, tir, chiefly as I set the path to the external libs I'm using. Though I would assume these CIs are run independently.

We need to figure it out a way that everybody can set their envs without interfering with each other.

kartelj commented 5 months ago

Hi Fabricio,

I accept the guilt :) However, it seems that this is not the problem :( I have removed os.environment settings from setup.py now, but ITEA, TIR and GPGOMEA still fail. https://github.com/kartelj/rils-rols/blob/master/setup.py

Does it fail without RILS-ROLS as well?

folivetti commented 5 months ago

looking at the history, it seems it was failing before rils-rols, so I think it's not your fault :-)

I´ ll have a look at that later!

lacava commented 5 months ago

Setting values to os.environment may be a reason to break itea, tir, chiefly as I set the path to the external libs I'm using. Though I would assume these CIs are run independently.

Yea, this shouldn't matter for ITEA/TIR, they are in a separate python environment

lacava commented 5 months ago

this looks good. once it finishes rebase and passes tests we should be good to merge. thanks for contributing a method!