No error in Response (in async) when checking with a bad checksum

cavaliergopher / grab

A download manager package for Go

BSD 3-Clause "New" or "Revised" License

1.39k stars 150 forks source link

No error in Response (in async) when checking with a bad checksum #11

Closed Skywalker13 closed 7 years ago

Skywalker13 commented 7 years ago

Hello,

When using client.DoAsync and the checksum functionality, if the checksum is different, this error is not available in resp.Error (this value is nil). I must check if the file exists in order to detect this sort of error because I've set RemoveOnError on the request.

Regards

Skywalker13 commented 7 years ago

Forget it.. my bad

cavaliercoder commented 7 years ago

Thanks for updating. In case anyone else stumbles on this, where was the confusion?

Skywalker13 commented 7 years ago

I was not testing the right error object... it was just a stupid mistake

But there is at least one point where it's a bit confusing according to http://cavaliercoder.com/blog/downloading-large-files-in-go.html

When using a checksum, the expected file size must be set too, otherwise the checksum is ignored