fix guessing filename from url if content-disposition header is missing

cavaliergopher / grab

A download manager package for Go

BSD 3-Clause "New" or "Revised" License

1.38k stars 151 forks source link

fix guessing filename from url if content-disposition header is missing #50

Closed hbakhtiyor closed 5 years ago

hbakhtiyor commented 5 years ago

cavaliercoder commented 5 years ago

Thanks for raising this. Please see my comments in #47. Happy to work with you so I can better understand what is happening.

I see the changes to guessFilename in your PR, but I don't see what has logically changed? Also, the new tests you created already pass without any changes - so it seems like they don't highlight the problem being solved or prevent regressions.

Again, I really appreciate the time you've put into this and hope we can find a great solution for you!

cavaliercoder commented 5 years ago

Closing due to inactivity. Please reopen if needed.