Grab can't determine filename with an URL where this looks pretty easy

cavaliergopher / grab

A download manager package for Go

BSD 3-Clause "New" or "Revised" License

1.39k stars 150 forks source link

Grab can't determine filename with an URL where this looks pretty easy #64

Closed CamilleScholtz closed 4 years ago

CamilleScholtz commented 5 years ago

URL in question: https://dl.google.com/go/go1.11beta1.src.tar.gz

Fails with both cmd/grab and using grab as a library, wget can correctly determine the filename.

grab output:

./grab https://dl.google.com/go/go1.13beta1.src.tar.gz
Downloading 1 files...
Error downloading https://dl.google.com/go/go1.13beta1.src.tar.gz: no filename could be determined
Finished 0 successful, 1 failed, 0 incomplete.

riyaz-ali commented 4 years ago

@onodera-punpun This is because dl.google.com is returning Content-Disposition header without any filename directive!