search

cavaliergopher / grab

A download manager package for Go
BSD 3-Clause "New" or "Revised" License
1.39k stars 150 forks source link

add go tip to travis tests #72

Closed oliverpool closed 4 years ago

oliverpool commented 4 years ago

The tests are failing on my local machine (using go 1.14).

I think that this is due to a change in http.NewRequest. Before proposing a fix, I want to be sure that this happens on travis as well.

oliverpool commented 4 years ago

This first failure is due to https://github.com/golang/go/commit/829c5df58694b3345cb5ea41206783c8ccf5c3ca Since since go1.12 invalid URLs fail to make a new request.

The second failure was just hanging forever, when the test server was returning an HTTP Status of 123. I changed this status to 418 and everything seems to be fine now.

oliverpool commented 4 years ago

@cavaliercoder do you mind merging this fix?