search

cavaliergopher / grab

A download manager package for Go
BSD 3-Clause "New" or "Revised" License
1.38k stars 151 forks source link

Possibly replace byteString with github.com/dustin/go-humanize #75

Open frezbo opened 4 years ago

frezbo commented 4 years ago

Would it be feasible to replace the byteString methods with the https://github.com/dustin/go-humanize library

cavaliercoder commented 4 years ago

What would be the advantage?

frezbo commented 4 years ago

@cavaliercoder The main difference being support for decimal part in download progress:

Downloading ca13b177ab4f9119c9f28a915b60707f88b2d456-primary.sqlite.bz2 **1.8 MB** / 68 MB (2%) - 62.28KB/s ETA: 17m49s

This is my local change