search

cavaliergopher / rpm

A Go implementation of the RPM file format
BSD 3-Clause "New" or "Revised" License
169 stars 44 forks source link

Fix stack overflow #13

Closed rpromyshlennikov closed 6 years ago

cavaliercoder commented 6 years ago

Thanks for submitting this PR. Your change to PackageFile.GetBytes did prevent a stack overflow, but didn't fix the underlying issue and make that function work. I've committed a fix to this issue and added tests (ref 5dab2aa).

The header length issue you raised will be addressed in PR #12 instead.

rpromyshlennikov commented 6 years ago

Yep, Ryan, it's my bad, I have not created new branch and sent PR from #12 code. Also I have not understood the logic, and thought that it should find tag in every header. It's great that you fixed that, thank you.

cavaliercoder commented 6 years ago

Thanks for your help!