Fix FileInfo.IsDir() - Githubissues

cavaliergopher / rpm

A Go implementation of the RPM file format

BSD 3-Clause "New" or "Revised" License

170 stars 44 forks source link

Closed vmagro closed 4 years ago

vmagro commented 4 years ago

The isDir field was not getting set anywhere - this commit updates the IsDir method to check the file mode against os.ModeDir

vmagro commented 4 years ago

Looks like a dependency failure on Go 1.4.x only, and since this diff does not touch any kind of dependencies, I am assuming it is unrelated

cavaliercoder commented 4 years ago

Looks good thanks. I just can’t merge with the failing test on my phone. Will merge later :)

cavaliercoder commented 4 years ago

It looks like this is negated by #20? If not, can you please resolve conflicts now that #20 has been merged. Many thanks.

vmagro commented 4 years ago

It is also included in #20