search

cavaliergopher / rpm

A Go implementation of the RPM file format
BSD 3-Clause "New" or "Revised" License
169 stars 44 forks source link

remove index item count validation - fail on item with valid index count #2

Closed chen-keinan closed 7 years ago

chen-keinan commented 8 years ago

Tested on a valid rpm file , appmon4j-agent-1.58.rpm , whilst opening this pkg , the index item count check failed even when the index item count is valid , I suggest to remove the index item count validation check

cavaliercoder commented 8 years ago

I'd rather understanding why it is failing. Can you please share the package which is failing validation so I can take a look? It doesn't make sense for it to include a header index with no value.

chen-keinan commented 8 years ago

I tried to debug it , the item index count was bigger then 0 however still it failed ,the package that is failing is : appmon4j-agent-1.58.rpm.zip

appmon4j-agent-1.58.rpm

cavaliercoder commented 7 years ago

I've check this package on a few different RPM tools, and it fails validation on all of them. For this reason, I tend to think my validation check is correct and should not be removed. If you are able to interrogate/install the above RPM package, can you please let me know what application and version you are using (including librpm, etc.)?

$ rpm -ivh appmon4j-agent-1.58.rpm 
error: appmon4j-agent-1.58.rpm: headerRead failed: hdr load: BAD
error: appmon4j-agent-1.58.rpm cannot be installed