search

cavaliergopher / rpm

A Go implementation of the RPM file format
BSD 3-Clause "New" or "Revised" License
169 stars 44 forks source link

Is it possible to make rpmvercmp a public function? #26

Closed ryysud closed 2 years ago

ryysud commented 2 years ago

Thank you for rewriting the original C implementation rpmvercmp in golang. Since this is a very useful function, is it possible to make it a public fucntion? https://github.com/cavaliergopher/rpm/blob/v1.1.1/version.go#L63

ryysud commented 2 years ago

@cavaliercoder Could you consider this?

cavaliercoder commented 2 years ago

Hey, yes I'm open to this. There is already the Compare public method, but perhaps you means comparison of strings?

ryysud commented 2 years ago

@cavaliercoder Yes, I want to compare versions as string type.

cavaliercoder commented 2 years ago

Added CompareVersions in v1.2.0

ryysud commented 2 years ago

Thank you for the quick fix 👍 I am closing this issue.