cavalle / steak

DISCONTINUED - The delicious combination of RSpec and Capybara for Acceptance BDD
MIT License
763 stars 32 forks source link

steak.gemspec contains é character - causes rake tasks to fail in some server environments #13

Closed enable closed 14 years ago

enable commented 14 years ago

After installing the Steak gem in our staging environment (using bundle install), we receive the following when running any rake task. (we are using ruby-1.9.2-rc1, rails-3.0.0.beta4, bundler-1.0.0.beta.2, Debian 5.0.2)

rake aborted!

/var/www/.rvm/gems/ruby-1.9.2-rc1/bundler/gems/steak-347880e/steak.gemspec:9: invalid multibyte char (US-ASCII)
/var/www/.rvm/gems/ruby-1.9.2-rc1/bundler/gems/steak-347880e/steak.gemspec:9: invalid multibyte char (US-ASCII)
/var/www/.rvm/gems/ruby-1.9.2-rc1/bundler/gems/steak-347880e/steak.gemspec:9: syntax error, unexpected $end, expecting ']'
gem.authors  = ["Luismi Cavallé"]

We don't encounter this problem in our development environment (OS X 10.6.4)

I know it's not ideal, but is be possible to alter the gemspec, to change gem.authors from ["Luismi Cavallé"] to ["Luismi Cavalle"] ? Otherwise, is it possible my UNIX server config (or ruby installation) needs correcting?

bebanjo commented 14 years ago

AFAIK Steak has never been tested under ruby 1.9.x. Ruby 1.9 is definitely in the TODO for Steak 1.0 which is the next milestone.

Patches to improve support for ruby 1.9.x, fixing this or other related issues, are welcome.

enable commented 14 years ago

Hi, we've had great success, so far, using Steak with Ruby 1.9.2. See the following commit, in our Steak Github fork, that fixes the issue for us:

http://github.com/enable/steak/commit/096c517fa8a3432d4330845ab9228c72b3d40585

bebanjo commented 14 years ago

I think this issue should also be solved by adding a comment like this at the top the file:

# encoding: utf-8

I'd rather do that and keep the "é" if possible

enable commented 14 years ago

Hi, yes your solution work perfectly (see commit below). Thanks a lot

http://github.com/enable/steak/commit/b23e643586a6f45c5bd8f021da4d036362b45774