search

caveman-dick / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

rubyripper does not save codec parameters if empty #539

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
When I configure rubyripper options to use the opus codec, it defaults to the 
parameter "--bitrate 160". I'd like to set this to "empty" (aka use opusenc's 
defaults).
While I can remove the content of the parameter field in preferences, it goes 
back to "--bitrate 160" every time I restart rubyripper.
It seems rubyripper is unable to save the state "empty fiel" for that option.
If I change it to something else, e.g. "--bitrate 140", it is still there next 
time I start rr, but not if I clean it or replace it with spaces. I can 
workaround this issue by adding something like "--quiet", which doesn't effect 
opusenc's operations, but it obviously is a bug how rubyripper saves options.

I'm using current git code with gtk2 interface.

Original issue reported on code.google.com by hanno@hboeck.de on 7 Oct 2012 at 10:21

GoogleCodeExporter commented 8 years ago 
I can see your point it's a "bug" in a technical way. But imagine you would be 
able to save an empty string. How would this effect the final encoding? Not by 
much I'd say.

Original comment by boukewou...@gmail.com on 8 Oct 2012 at 6:14

GoogleCodeExporter commented 8 years ago 
I fixed it anyway (it was a loading problem, not a saving problem):
http://code.google.com/p/rubyripper/source/detail?r=e719351bd2f3c49083f418d60a62
7a9101e2dcc7

Original comment by boukewou...@gmail.com on 20 Oct 2012 at 5:47