search

caveman-dick / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Musicbrainz lookup fails if there's a _ in the discid (patch attached) #549

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I saw out that musicbrainz failed and falled back to freedb in a lot of cases. 
The reason is that the code for calculating the discid has a slight error: it 
doesn't replace / with _ 

The code in question is in calcMusicbrainzID.rb:
@discid.gsub!(/[+\\=]/, {'+' => '.', '/' => '_', '=' => '-'})

Although it has '/' => '_', that has no effect, cause / doesn't get searched in 
the first place. Correct is this:
@discid.gsub!(/[+\\=\/]/, {'+' => '.', '/' => '_', '=' => '-'})

Patch attached, please apply.

Original issue reported on code.google.com by hanno@hboeck.de on 27 Dec 2012 at 4:33

Attachments:

GoogleCodeExporter commented 8 years ago 
Just merged, thanks for the patch :)

http://code.google.com/p/rubyripper/source/detail?r=909601a97afbd866031e9960d733
ee2f515cc030

Original comment by boukewou...@gmail.com on 27 Dec 2012 at 7:35