caveman-dick / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Ruby 2.0 is different from ruby 1.9 with characters encoding. #566

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1) Please describe the steps to reproduce the situation:
a.Put a CD : OK
b.Scan drieve : OK
c.Rip CD

2) What is the expected output? What do you see instead?
Rubyripper crashes

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?
Last version of Rubyripper (0.6.2-3) and ruby 2.0.0

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.
yes

6) Please explain why this change is important for you. Also, how many
users would benefit from this change?

Please provide any additional information below. The more usefull
information provided, the sooner the issue will be fixed.

Note that ruby versions older than 1.9 are no longer supported. You are
advised to upgrade instead.
The problem is probably due to the evolution from ruby 1.9 to 2.0, because 
encoding characters is different.

/mnt/Win7/Tmp/Flac/classical/piano works
/usr/lib/ruby/vendor_ruby/2.0.0/rr_lib.rb:1659:in `gsub!': incompatible 
encoding regexp match (UTF-8 regexp with ASCII-8BIT string)
     from /usr/lib/ruby/vendor_ruby/2.0.0/rr_lib.rb:1659:in `allFilter'
     from /usr/lib/ruby/vendor_ruby/2.0.0/rr_lib.rb:1636:in `tagFilter'
     from /usr/lib/ruby/vendor_ruby/2.0.0/rr_lib.rb:1597:in `block in setMetadata'
     from /usr/lib/ruby/vendor_ruby/2.0.0/rr_lib.rb:1596:in `times'
     from /usr/lib/ruby/vendor_ruby/2.0.0/rr_lib.rb:1596:in `setMetadata'
     from /usr/lib/ruby/vendor_ruby/2.0.0/rr_lib.rb:1479:in `attemptDirCreation'
     from /usr/lib/ruby/vendor_ruby/2.0.0/rr_lib.rb:1685:in `overwriteDir'
     from /usr/lib/ruby/vendor_ruby/2.0.0/rr_lib.rb:2661:in `overwriteDir'
     from /usr/bin/rrip_gui:1372:in `block in initialize'
     from /usr/bin/rrip_gui:1486:in `call'
     from /usr/bin/rrip_gui:1486:in `main'
     from /usr/bin/rrip_gui:1486:in `<main>'

Original issue reported on code.google.com by christia...@gmail.com on 28 Apr 2013 at 1:14

GoogleCodeExporter commented 8 years ago
The rspec tests were also failing because of this. Just fixed it:
https://code.google.com/p/rubyripper/source/detail?r=a59a5a350efbe7257076cde81fb
0e1927c69a2e6

Original comment by boukewou...@gmail.com on 9 May 2013 at 10:59