caverav / auditforge

AuditForge is a pentest reporting application making it simple and easy to write your findings and generate a customizable report.
https://auditforge.feriadesoftware.cl
MIT License
20 stars 0 forks source link

💄 style: update to auditforge logo #101

Closed caverav closed 1 month ago

caverav commented 1 month ago

Descripción

Se cambia el logo al de la aplicación

Motivación y Contexto

Se estaba usando logo del equipo en vez de la aplicación

¿Cómo ha sido probado?

Correr la app y que se vea el nuevo logo

Tipos de cambios

Lista de verificación:

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

[!IMPORTANT]

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (6) * `frontend/public/android-chrome-192x192.png` is excluded by `!**/*.png` * `frontend/public/android-chrome-512x512.png` is excluded by `!**/*.png` * `frontend/public/apple-touch-icon.png` is excluded by `!**/*.png` * `frontend/public/auditforgelogo.png` is excluded by `!**/*.png` * `frontend/public/favicon-16x16.png` is excluded by `!**/*.png` * `frontend/public/favicon-32x32.png` is excluded by `!**/*.png`

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough ## Walkthrough Se han realizado cambios en varios componentes de la interfaz de usuario, específicamente en las imágenes de los logotipos. En todos los casos, la fuente de la imagen se ha actualizado de un archivo PNG (`/auditforgelogo.png`) a un archivo SVG (`/logo.svg`). Esta modificación afecta a los componentes `LoginForm`, `Navbar`, `ErrorPage` y `Register`, aunque no altera la estructura o funcionalidad general de los mismos. Además, se ha simplificado la declaración de los favicons en el archivo `index.html`. ## Changes | Archivo | Resumen de cambios | |-------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------| | `frontend/src/components/login/LoginForm.tsx`, `frontend/src/components/navbar/Navbar.tsx`, `frontend/src/error-page.tsx`, `frontend/src/routes/register.tsx` | Se ha cambiado la fuente de la imagen del logotipo de `/auditforgelogo.png` a `/logo.svg`. No se realizaron alteraciones en la funcionalidad o estructura de los componentes. | | `frontend/index.html` | Se han eliminado tres elementos de favicon en formato PNG y se ha añadido un nuevo favicon en formato ICO. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant LoginForm participant Navbar participant ErrorPage participant Register User->>LoginForm: Cargar página de inicio de sesión LoginForm->>User: Mostrar formulario de inicio de sesión con logo SVG User->>Navbar: Cargar página principal Navbar->>User: Mostrar barra de navegación con logo SVG User->>ErrorPage: Acceder a página de error ErrorPage->>User: Mostrar página de error con logo SVG User->>Register: Cargar página de registro Register->>User: Mostrar formulario de registro con logo SVG ```

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > :bangbang: **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
iTzGooDLife commented 1 month ago

Consulta antes de aprobar, también se debería cambiar el logo que aparece en las tabs, cierto? Por ejemplo:

image

jllanosg commented 1 month ago

Consulta antes de aprobar, también se debería cambiar el logo que aparece en las tabs, cierto? Por ejemplo:

image

ese se llama favicon, y tengo la misma duda, en el diff sale como si se hubiera modificado pero a mi me aparece el mismo; puede ser tema de caché?

iTzGooDLife commented 1 month ago

ese se llama favicon, y tengo la misma duda, en el diff sale como si se hubiera modificado pero a mi me aparece el mismo; puede ser tema de caché?

Sip, aparece modificado, pero no es tema del caché. Revisé /public y aún hay varias versiones del antiguo logo (AF) (favicon-16x16.png, favicon-32x32.png, etc...). En mi caso cambié el favicon-16x16.png y se cambió en el navegador, hay que cambiar esas versiones.

caverav commented 1 month ago

Aunque se cambió el favicon.ico, hay que cambiar los otros png's dentro del directorio /public. #101 (comment)

Los eliminé, no son necesarios