search

caverav / auditforge

AuditForge is a pentest reporting application making it simple and easy to write your findings and generate a customizable report.
https://auditforge.feriadesoftware.cl
MIT License
21 stars 0 forks source link

feat: add severity none to cvss calculator box #142

Closed iTzGooDLife closed 1 month ago

iTzGooDLife commented 1 month ago

Descripción

Se agrega la severidad informativa en el cvss calculator (severidad 0). Actualmente afecta al editar y añadir vulnerabilidades..

Motivación y Contexto

No hay un ticket sobre eso, pero es un problema actual.

¿Cómo ha sido probado?

Al editar y añadir vulnerabilidades se calcula algo con severidad 0, como se ve en la imagen adjunta:

Capturas de pantalla (si es apropiado):

image

Tipos de cambios

Lista de verificación:

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough Los cambios en el componente `ScoreBox` implican la adición de una nueva rama condicional que maneja un caso específico cuando el `score` es igual a 0 y `isComplete` es verdadero. En este caso, el `rating` se establece en la traducción para 'none', y el `bgColor` se actualiza a un color verde específico (`bg-[#53AA33]`). Esta modificación altera el flujo de control al introducir una verificación adicional del valor del score, afectando así la representación del componente según el valor del score y el estado de completitud. ## Changes | Archivo | Resumen de cambios | |-------------------------------------------------|-------------------------------------------------------------------------------------------------------| | frontend/src/routes/vulnerabilities/components/scoreBox.tsx | Se agregó una nueva rama condicional para manejar el caso cuando `score` es 0 y `isComplete` es verdadero, ajustando el `rating` y el `bgColor`. | ## Suggested reviewers - caverav

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
caverav commented 1 month ago

Creo que el None lo deberíamos dejar con el mismo color que los informativos (#00A8FF)

iTzGooDLife commented 1 month ago

Creo que el None lo deberíamos dejar con el mismo color que los informativos (#00A8FF)

Saqué el hex desde https://www.first.org/cvss/calculator/3.1#CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:N . De donde sacaste ese color?:0

caverav commented 1 month ago

Creo que el None lo deberíamos dejar con el mismo color que los informativos (#00A8FF)

Saqué el hex desde https://www.first.org/cvss/calculator/3.1#CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:N . De donde sacaste ese color?:0

De lo que hemos estado ocupando en el dashboard, si prefieren ocupar ese está bien, pero tendré que cambiarlo en el dashboard, no tengo problema con eso btw, pero hay que acordarlo

iTzGooDLife commented 1 month ago

Creo que el None lo deberíamos dejar con el mismo color que los informativos (#00A8FF)

Saqué el hex desde https://www.first.org/cvss/calculator/3.1#CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:N . De donde sacaste ese color?:0

De lo que hemos estado ocupando en el dashboard, si prefieren ocupar ese está bien, pero tendré que cambiarlo en el dashboard, no tengo problema con eso btw, pero hay que acordarlo

Ahh, entiendo, considero que se debería usar este color por lo mencionado arriba, asi que pido modificar el color en el dashboard porfas.