caverav / auditforge

AuditForge is a pentest reporting application making it simple and easy to write your findings and generate a customizable report.
https://auditforge.feriadesoftware.cl
MIT License
21 stars 0 forks source link

Remove Unavailable Options in Company and Clients to Prevent App Crashes #168

Closed iTzGooDLife closed 13 hours ago

iTzGooDLife commented 6 days ago

Descripción

Se quitan las opciones "unavailable" que se agregan al no encontrar clientes y compañías.

Importante:

Motivación y Contexto

Arregla un problema actual, el cual es que la aplicación se crashea si es que uno selecciona alguna de las opciones "unavailable".

¿Cómo ha sido probado?

Para probar los cambios se debe crear una auditoria sin clientes y/o compañias y ver como no aparece la opción de "unavailable" y por ende, no se crashea. Se puede contrastar con la versión actual de development y ver el comportamiento.

Capturas de pantalla (si es apropiado):

Tipos de cambios

Lista de verificación:

Summary by CodeRabbit

coderabbitai[bot] commented 6 days ago
📝 Walkthrough ## Walkthrough El cambio principal en el componente `General` de `frontend/src/routes/audits/edit/general/general.tsx` se centra en la gestión de las opciones de empresa y cliente dentro de la lógica de recuperación de datos. Ahora, si no hay opciones disponibles, se asignan arreglos vacíos a `companyOptions` y `clientOptions`, eliminando la opción por defecto que indicaba la falta de disponibilidad. Además, se han ajustado las condiciones para la recuperación de datos de auditoría, eliminando las opciones de empresa y cliente del arreglo de dependencias de `useEffect`, lo que puede modificar el flujo de control en la obtención de datos. ## Changes | Archivo | Resumen de cambios | |----------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------| | `frontend/src/routes/audits/edit/general/general.tsx` | Se modificó la lógica para manejar `companyOptions` y `clientOptions`, asignando arreglos vacíos en lugar de opciones por defecto. Se eliminaron las opciones del arreglo de dependencias de `useEffect` para la recuperación de datos de auditoría. La estructura general y el manejo del estado permanecen sin cambios. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant GeneralComponent participant DataFetcher User->>GeneralComponent: Interactuar con el componente GeneralComponent->>DataFetcher: Solicitar datos de la empresa y cliente DataFetcher-->>GeneralComponent: Retornar opciones (vacías si no hay) GeneralComponent->>GeneralComponent: Actualizar estado con opciones GeneralComponent->>DataFetcher: Recuperar datos de auditoría DataFetcher-->>GeneralComponent: Retornar datos de auditoría GeneralComponent->>User: Mostrar datos de auditoría ```

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
jllanosg commented 5 days ago

No entiendo, debo crear una auditoría sin clientes ni compañías creadas? En ese caso, no sería mejor obligar al usuario a crearlas?

iTzGooDLife commented 5 days ago

No entiendo, debo crear una auditoría sin clientes ni compañías creadas? En ese caso, no sería mejor obligar al usuario a crearlas?

Según yo, no. No es la idea que un usuario tenga que crear obligatoriamente un cliente y/o compañía para poder hacer uso de audits, sobretodo si estos no son campos obligatorios. Lo que se menciona de crear una auditoria sin clientes ni compañias creadas, es un caso de prueba para los cambios realizados, tipo para contrastar a lo que sucede actualmente.