search

cavi-au / Consent-O-Matic

Browser extension that automatically fills out cookie popups based on your preferences
Other
2.53k stars 123 forks source link

uk.rs-online.com rule conflict with www.postoffice.co.uk #403

Closed wildwizzy closed 7 months ago

wildwizzy commented 8 months ago

The uk.rs-online.com rule works fine, but www.postoffice.co.uk which uses almost the same configuration as uk.rs-online.com doesn't work. The reason is the OPEN_OPTIONS selector for postoffice is #ensOpenModal whereas for rs-online it is #ensModalBanner. There are also some differences with the button IDs so it would make sense to have a separate rule. As only one rule can run this means the uk-rs-online.com rule will need to be modified so it is not triggered with postoffice, probably by specifying the URL for rs-online and also postoffice. Of course by doing this if there is a site that uses the same configuration this will no longer work with the rs-online rule. Is there a better solution?

This also happens with the tealium.com rule that triggers but doesn't work with www.royalmail.com.

After further investigation I think it would be best to use IfCssActions where the differences occur. I have tested this and it works correctly. I will create a pull request so you can check if you are happy with this solution. #405

wildwizzy commented 7 months ago

Pull request created and merged.