caxanga334 / cvreduxmodified

Modified version of ReFlexPoison's custom votes
GNU General Public License v3.0
15 stars 9 forks source link

Can't use {VOTER_NAME} in command part #14

Closed yarik2720 closed 4 years ago

yarik2720 commented 5 years ago

Describe the bug In commands {VOTER_NAME} is not showing player name that started vote

To Reproduce Steps to reproduce the behavior:

    "Mute player"
    {
        "type"          "players"
        "vote"          "1"
        "minimum"       "2"
        "cooldown"      "100"
        "ratio"         "0.64"
        "command"       "sm_silence #{TARGET_ID} 30 Muted by voting - {VOTER_NAME}"
        "start_notify"  "{olive}[SM] {default}{VOTER_NAME} started a vote to mute {red}{TARGET_NAME}{default}."
        "call_notify"   "{olive}[SM] {default}Vote cast for {yes|no}."
        "pass_notify"   "{olive}[SM] {default}Vote passed."
        "fail_notify"   "{olive}[SM] {default}Vote failed. Received: {VOTE_AMOUNT} Required: {VOTE_REQUIRED}"
        "chattrigger"   "votemute"
    }

[SourceComms++] Console: Issued an extended silence on Fabler for 30 minutes (reason: Muted by voting - {VOTER_NAME}).

Expected behavior [SourceComms++] Console: Issued an extended silence on Fabler for 30 minutes (reason: Muted by voting - Nickname).

Screenshots synergy_2019-04-05_21-07-14

Game Server

caxanga334 commented 5 years ago

This could potentially allow people to run any commands on the server.

https://forums.alliedmods.net/showpost.php?p=2579011&postcount=270

This is the same reason you shouldn't use {TARGET_NAME} on command.

yarik2720 commented 5 years ago

Ok, I understand. Issue can be closed