caxanga334 / cvreduxmodified

Modified version of ReFlexPoison's custom votes
GNU General Public License v3.0
15 stars 9 forks source link

Map voting - Fix memory leak and broken logic: #22

Closed Adrianilloo closed 3 years ago

Adrianilloo commented 3 years ago

So, I decided to investigate issue #15 and this led me to finding out the source of a memory leak - map voting recent maps management.

Not only that, but it turns out that testing map voting configurations (which I wasn't using, since I don't want to replace rtv and such) arised that map voting initial menu display was broken in different ways, as you can see in more detail in the commit message.

Hoping that the mentioned leak fix was the only existing one, it turns out there's at least another I haven't catched yet: switching map creates 6 more unrelated handles - I'll keep investigating.

Meanwhile, I hope this PR helps for what it can :)

caxanga334 commented 3 years ago

Thank you.