caxanga334 / tf-bewithrobots-redux

A TF2 plugin that allows players to play in the robot team in MvM.
GNU General Public License v3.0
16 stars 7 forks source link

Deploy animation does not always play #23

Open Comicsanswich opened 1 year ago

Comicsanswich commented 1 year ago

Help us help you

Environment

Description

I noticed that when any player robot deploys the bomb it does not always play the deploy animation like with TFbot robots this applies to classes that do have a deploy animation.

Video

Here's the video of the bug the file is too big for GitHub so I uploaded it to discord https://cdn.discordapp.com/attachments/1087494790733639771/1103033519778840596/Team_Fortress_2_-_OpenGL_2023-05-02_14-51-09.mp4

Steps to reproduce

Grab the bomb/flag, go to the deploy area and deploy the bomb

caxanga334 commented 1 year ago

I was unable to reproduce this issue. Even with simulated latency and packet loss the animation still played correctly.

Comicsanswich commented 1 year ago

I was unable to reproduce this issue. Even with simulated latency and packet loss the animation still played correctly.

This is from officer spy's server he allowed me to use his video here it is: https://streamable.com/91zugd

He also says he's not entirely sure how this works but it sometimes does glitch as a result of stopping the animations.

OfficerSpy commented 1 year ago

I was unable to reproduce this issue. Even with simulated latency and packet loss the animation still played correctly.

This is from officer spy's server he allowed me to use his video here it is: https://streamable.com/91zugd

He also says he's not entirely sure how this works but it sometimes does glitch as a result of stopping the animations.

I meant it was the class animations being disabled, though I don't know if this is the cause as I've seen the animation play most of the time.

caxanga334 commented 1 year ago

This is from officer spy's server he allowed me to use his video here it is: https://streamable.com/91zugd

The video suggests a possibility of the animation being cancelled due to movement input but the player's input is already being disabled by TF_COND_FREEZE_INPUT. Moving and jumping during the deploy sequence didn't trigger the issue.

I meant it was the class animations being disabled, though I don't know if this is the cause as I've seen the animation play most of the time.

Couldn't notice any difference with class animations enabled. Still couldn't reproduce the issue.

Comicsanswich commented 1 year ago

I'll just leave this open until there is a solution and/or you're able to reproduce the issue.

TehPlayer14 commented 4 months ago

This is very cursed bug, for some it always plays, others its 50/50 and one person I knew it never played at all

This is why BWR2 used dynamic_prop to play animation of deploy, it could also be used to fix medic's deploy animation delay