Added compatibility to rails 6.0 default_formats

caxlsx / caxlsx_rails

A Rails plugin to provide templates for the axlsx gem

MIT License

744 stars 84 forks source link

Added compatibility to rails 6.0 default_formats #121

Closed correalucas closed 5 years ago

correalucas commented 5 years ago

Fix to ArgumentError (Invalid formats: #<Mime::Type: @synonyms=[], @symbol=:xlsx, @string="application/vnd.openxmlformats-officedocument.spreadsheetml.sheet", @hash=>'some_hash') after upgrade to rails 6.0

coveralls commented 5 years ago

Coverage decreased (-3.01%) to 92.667% when pulling 6fc3d02730aff0534273794252cec0849ce6ba35 on correalucas:master into 4e9a8d714198c429828fcb3be815d14116a1730c on straydogstudio:master.

straydogstudio commented 5 years ago

Nice work @correalucas. I need to dig into the failed Travis testing. Are you using this currently? I assume your testing worked since you created dummy_6 and all of the supporting scripts? If it is working for you I will merge it before I get to fixing Travis.

correalucas commented 5 years ago

Hey @straydogstudio, thanks! I was trying to fix rails 6 dummy tests and now i think they are ok in rails 5 and 6. But I couldn't ran the tests in older rails versions.