search

caxlsx / caxlsx_rails

A Rails plugin to provide templates for the axlsx gem
MIT License
742 stars 84 forks source link

Do not publish spec files to rubygems #149

Closed Liboul closed 3 years ago

Liboul commented 3 years ago

Hello 👋

What is this PR?

Making sure that the spec/ folder is not published to rubygems. As RubyGems points out, the test_files option is ignored

Why?

The specs are no use to the end user, and they inflate the project size. Heroku's slug size cap is 500 MB, the specs of this gem account for 14.7 MB. This change is important for us, as the limit of 500 MB has been reached.

Currently 👇

image

After this PR:

image

straydogstudio commented 3 years ago

@Liboul Nice catch.

gee-forr commented 2 years ago

Hi there,

Is there any chance that we could get this released to rubygems? I'm also struggling with a large slug size which would be greatly reduced if specs were not included.

straydogstudio commented 2 years ago

@gee-forr Sorry it has taken so long to get to this. I wanted to fix the CI build error, but there is a strange Rails 6 problem only in the testing environment that I've not been able to solve yet.

straydogstudio commented 2 years ago

2.6.3 released

gee-forr commented 2 years ago

@gee-forr Sorry it has taken so long to get to this. I wanted to fix the CI build error, but there is a strange Rails 6 problem only in the testing environment that I've not been able to solve yet.

Please don't apologise - we all lead crazy lives. Thank you for handling this silly minor issue, it's very much appreciated!