search

caxlsx / caxlsx_rails

A Rails plugin to provide templates for the axlsx gem
MIT License
744 stars 84 forks source link

Lazy load with railtie / frozen_string_literal / latest ruby versions #97

Closed ericproulx closed 6 years ago

ericproulx commented 6 years ago

Hi,

Simply lazy_loading everything in railtie. I also added the meta # frozen_string_literal: true and I updated the ruby versions in travis.yml.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.8%) to 98.161% when pulling bffe04b047d97a700daeebf2fe6ce8ddbd527a03 on ericproulx:master into c8acfcde4ddff166ebf2a5c9612457b2b53127a3 on straydogstudio:master.

straydogstudio commented 6 years ago

Thanks for the work Eric. I'll get a good look at it in the next month.

straydogstudio commented 6 years ago

Thanks for the work on this @ericproulx. I've not done much with rail ties and lazy loading.

ericproulx commented 6 years ago

Thanks, do you know when you'll release v0.5.2 ?

straydogstudio commented 6 years ago

Sometime in the next few months. I may do it sooner to release the work you've done. Would that help you? If Axlsx gets a new release I will do it immediately to fix the Rubyzip dependency problems. Outside of the Rail tie, there really isn't much difference between master and 0.5.1.

ericproulx commented 6 years ago

It would help me but no stress.