search

caxy / php-htmldiff

A library for comparing two HTML files/snippets and highlighting the differences using simple HTML. Includes support for comparing complex lists and tables
http://php-htmldiff.caxy.com
GNU General Public License v2.0
202 stars 51 forks source link

ICC-4313 | ICC-4314 | Replace Special HTML Elements with placeholder tokens and update diffing logic #11

Closed usaqlain01 closed 9 years ago

usaqlain01 commented 9 years ago

https://caxyinteractive.atlassian.net/browse/ICC-4313

jschroed91 commented 9 years ago

Just a few comments -- the naming change will most likely affect a lot of the changes, but I definitely think it's worth doing in order to be very clear what the purpose of the property and functions related to it are doing.

usaqlain01 commented 9 years ago

Code Review Adressed

jschroed91 commented 9 years ago

Just a few more comments -- this is looking good, thanks for making the updates to the naming

usaqlain01 commented 9 years ago

No prob Josh, Second code review comments addressed.

jschroed91 commented 9 years ago

Looks good -- merging into the table diffing branch, then I'll pick out the isolated diff tags work you did here and get that merged into master :+1: