search

caxy / php-htmldiff

A library for comparing two HTML files/snippets and highlighting the differences using simple HTML. Includes support for comparing complex lists and tables
http://php-htmldiff.caxy.com
GNU General Public License v2.0
202 stars 51 forks source link

Does not work on PHP 5.3.10 #61

Closed burgoyn1 closed 7 years ago

burgoyn1 commented 7 years ago

The ListDiffLines.php file uses [ ] as declaring arrays which is not supported in PHP 5.3 so composer will need to be updated to be greater than 5.3 or the array declaration will need to be changed.

"As of PHP 5.4 you can also use the short array syntax, which replaces array() with []."

burgoyn1 commented 7 years ago

Line 63 of LcsServices.php also has the same issue.

jschroed91 commented 7 years ago

@myfriend12 Is this the only compatibility issue with 5.3? If so, I'm okay with updating it to use array() instead of [] in order to restore 5.3 support

burgoyn1 commented 7 years ago

Yes, from what I can see running on my code that is the only compatibility issue. I did a fork and pull which just passed the tests.

jschroed91 commented 7 years ago

Thank you @myfriend12! This has been merged, and I can tag a new release

jschroed91 commented 7 years ago

Tagged a new release v0.1.4 with this fix

burgoyn1 commented 7 years ago

Awesome thanks. Love this package by the way.