search

caxy / php-htmldiff

A library for comparing two HTML files/snippets and highlighting the differences using simple HTML. Includes support for comparing complex lists and tables
http://php-htmldiff.caxy.com
GNU General Public License v2.0
202 stars 51 forks source link

Fixed warnings "count(): Parameter must be an array... #65

Closed di-maroo closed 6 years ago

di-maroo commented 7 years ago

When running the code under PHP 7.1, I'm getting this:

Warning: count(): Parameter must be an array or an object that implements Countable in 
./vendor/caxy/php-htmldiff/lib/Caxy/HtmlDiff/HtmlDiff.php on line 719

Warning: count(): Parameter must be an array or an object that implements Countable in 
./vendor/caxy/php-htmldiff/lib/Caxy/HtmlDiff/HtmlDiff.php on line 570

There are two reasons: 1) attempt to use count() on an object which doesn't implement Countable 2) attempt to use count() on a string

jschroed91 commented 6 years ago

Hi @yojick thank you for the pull request - not sure how I missed this for so long... I’ll have this reviewed this week

sdkcarlos commented 6 years ago

When will be this pull request merged?

jschroed91 commented 6 years ago

Merged! Thank you @yojick

sdkcarlos commented 6 years ago

Thank you @jschroed91 and @yojick , however the Packagist package stills on the v.0.1.5, do you have the hooks of the repository correctly configured?

jschroed91 commented 6 years ago

I will need to tag a new release @sdkcarlos I’ll do that now