Closed danepowell closed 3 years ago
In my opinion, before this is merged, the demo css should be made available from another path, as it is an easy to use default CSS styling for anyone using the bundle.
Or, even better, maybe it should be offered as SCSS file.
@danepowell You're very right, we should exclude these for sure. Thanks @bobvandevijver for the note, I agree with that. Will get to this later this week.
Hi @jschroed91 !
Any chance this PR will be merged soon?
We want to use it for an open source project called YesWiki but having a 1mb dependency instead of a 10mb one would be great!
@mrflos Oh, yes let's get this in. I'll take a look after work unless @SavageTiger has any concerns with it, or if he beats me to it
@mrflos This has been merged and included in release v0.1.13 - thank you @danepowell
Thank you all very very much!
The size of php-htmldiff on disk is 10MB. This may not sound like much, but that could easily make it the single largest package in any given Composer install. This could be easily reduced to <1MB by simply excluding the demos and tests from packaged releases. Anyone who still wants access to those files would still get them by simply cloning from source, but the thousands of other projects simply using this as a library would save a ton of bandwidth and build time. (literally something like 16TB across the 1.6M installs of this project.)
This is an increasingly common pattern for Composer libraries, following the strategy outlined here.