Closed daum closed 3 years ago
Let me know if you need anything else on it.
@jschroed91 Did you need anything else done on this PR?
@jschroed91 Do you have an update for when you think this may be merged?
Hi 👋
Its been a while, but I have looked into this PR.
However I am a bit confused about it, since the preposed changes are both in the intertTag
method, and the method gets called from processInsertOperation
or processDeleteOperation
and both those methods initiate a array that can never be null
. So for now I am closing this PR.
If I am mistaken, feel free to let me know.
As of PHP 7.2 if you pass count(null) it'll emit a warning of
Parameter must be an array or an object that implements Countable in …
This makes sure that the$words
is actually an array and not null, so it is in fact countable.