search

caydey / ffshare

An android app to compress image, video and audio files through ffmpeg before sharing them
GNU General Public License v3.0
616 stars 30 forks source link

Add ffmpeg options to be manually changed #5

Closed tiziodcaio closed 2 years ago

tiziodcaio commented 2 years ago

For example, adding h265 support

G2G2G2G commented 2 years ago

agreed, I want to use h264, or any codec from this century would be fine with me. But it is hard coded for mpeg4

G2G2G2G commented 2 years ago

@caydey what do we do, is there no codec set at all? Doesn't look like there is

image we just set this here? IDK how to build, I've never built an app, especially not kotlin.

I looked through all the params and I see no mention of codecs or anything of the sort. I guess making it an option would be better but h264 is supported by everything

caydey commented 2 years ago

The libx264 is not available because I'm using the 'full' version of ffmpeg-kit not 'full-gpl', I'm working on changing it now and will make h264 the default video encoder in the next release.

caydey commented 2 years ago

I've done some testing with the h265 (hevc) codec and it is painfully slow on mobile devices with little to no size reduction so I will not be including it at the moment. I've made h264 the default codec for videos. I don't want to make the ffmpeg command manually changeable as different different commands are ran based on different options and input files.