cayennegoh / pe

0 stars 0 forks source link

Incorrect error message output for remove genre #3

Open cayennegoh opened 2 months ago

cayennegoh commented 2 months ago

When calling remove genre 1 to a list which does not contain any books, the programme should tell me to add books to the list or add genre to the list first. However, it tells me that 1 is not a valid integer which is incorrect. image.png

nus-se-bot commented 2 months ago

Team's Response

Hi! Thanks for bringing this up!

You seem to have been mistakened with the usage of the programme.

As seen from your screenshot, you're entering the "remove-genre 1" with the single identation, which is the part where you are supposed to input an integer.

image.png

When the list is empty and you try to set-genre to a non-existent book index, the programme will inform you:

image.png

Hope this clarifies!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I understand after your explanation, that this is the part where I am supposed to input an integer. image.png However, as seen from the image, the first command is telling me to "Enter the number for the desired genre, or add a new one, or 'exit' to go back" which is accurate and helpful. However, after keying in the wrong command again by not inputting an integer to set genre, the output becomes "l is not a valid integer man.. try again.. or 'exit' to go back". This is where it gets confusing. Previously, it was clear to some extent that I was still in the set-genre command and that exit meant going back to the home page where the normal commands can be used since it comes after telling me to enter the number for the desired genre...However, from the second error message onwards, it just tells me to 'try again' which had me confused as to what I had to try again for, since I thought I was already in the home page hence keying in any valid command should work, such as "add Book". image.png Besides, I also mistook the 'exit' command now as exiting the application, since I was under the false impression that I was in the homepage and there was no helpful message to tell me that I am not. Hence I disagree that this is not a bug as it should still be a bug of low severity as if users are not aware that they have to exit this command, the app would be almost unusable since users, like me, will keep keying in valid commands in the set-genre command only to receive message that it is not a valid integer, leaving them confused and not exiting the command since they would have the thought that it would exit the app.