accept kana combination cards

cayennes / kanji-colorize

a script and anki addon to turn KanjiVG data into colored stroke order diagrams

119 stars 26 forks source link

accept kana combination cards #36

Closed cayennes closed 4 years ago

cayennes commented 9 years ago

(from an email)

Things like じゃ as the full content should have diagrams.

Desired behavior:

If there are kanji on the card, only do diagrams for the kanji. Some people want diagrams for the kanji in their sentences.
Otherwise do diagrams for everything.

Bonus:

Add a setting that can let people optionally always have diagrams for everything.

emekoi commented 4 years ago

this doesn't seem like a difficult fix so i will try to submit a PR, but where did you get the bounds for this function? they don't seem to align with the SVGs, kanjivg has.

cayennes commented 4 years ago

Those numbers come from the unicode values of the kanji range to differentiate kanji from other characters. You're right this is an easy fix; it just needs the conditional to check whether the string has kanji rather than whether it is a single character.

I've updated the description to specify what the actual desired behavior is.