search

cayennes / kanji-colorize

a script and anki addon to turn KanjiVG data into colored stroke order diagrams
121 stars 25 forks source link

Editing Bug #41

Closed Quinnlet closed 6 years ago

Quinnlet commented 6 years ago

I keep getting this error when editing my deck:

Traceback (most recent call last): File "aqt/progress.pyc", line 69, in handler File "aqt/editor.pyc", line 468, in onUpdate File "aqt/editor.pyc", line 540, in loadNote AttributeError: 'NoneType' object has no attribute 'media'

It shows the "click here to resume" screen when coming out of editing, and does it every time I edit my cards and it forces me to restart Anki - this can be quite frustrating when having to edit multiple cards, and it really is a shame as this addon is so useful!

cayennes commented 6 years ago

Thanks for the report.

Can you create a one-card deck that reproduces the issue and attach it here?

cayennes commented 6 years ago

(Also I don't make any promises about when I will find time to work on this)

alexpizarroj commented 6 years ago

I've finished working on a fix for this.

This is an excerpt of a comment on the AnkiWeb add-on page. It explains how to reproduce the issue:

The bug [...] that causes error messages and "Waiting for editing to finish/Resume Now" over and over, is still there. [...] The way to cause this error is to start studying your card deck, and get to a card containing a colorized kanji, then clicking Edit and then Done and it will happen.

What I found out was that there's something weird going on when you hit the Close button while using the Edit Note dialog (it won't happen if you just close the window hitting the ESC key). The addKanji function will be called indefinitely unless we signal that we have not made any changes to the current note through the return value of addKanji (i.e. return flag).

Since I've also heard other people complain about the add-on re-writing the Diagram field whenever you mistakenly cycle through the Kanji field, I feel that just avoiding filling a non-empty Diagram field should be the way to go.

Let me know what you think. If there's something else to be done, I'd gladly help.

Quinnlet commented 6 years ago

Hey Cayennes! Thanks for the speedy reply, and I made a one card deck like you suggested. I am not sure how to change the format of files and it wouldn't let me drag and drop the Anki deck directly into this text box so I put it on Google Drive. If not might need some guidance on how to attach on this site.

But the bug is just how Alex suggests - I open the card I want, click space to see both front and back then go to editing, once coming out of editing that's when the bug happens.

And thanks! I didn't know that pressing the esc key would work, but it seems to. :))

cayennes commented 6 years ago

Thanks both of you! I'll have time to look at this and should be able to make a new release tomorrow

On Dec 21, 2017, at 8:25 AM, Quinnlet notifications@github.com wrote:

Hey Cayennes! Thanks for the speedy reply, and I made a one card deck like you suggested. I am not sure how to change the format of files and it wouldn't let me drag and drop the Anki deck directly into this text box so I put it on Google Drive. If not might need some guidance on how to attach on this site.

But the bug is just how Alex suggests - I open the card I want, click space to see both front and back then go to editing, once coming out of editing that's when the bug happens.

And thanks! I didn't know that pressing the esc key would work, but it seems to. :))

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Quinnlet commented 6 years ago

Looking forward to the new release! I'll keep an eye out on Anki addon site. Thanks so much for resolving it quickly, and also have a merry xmas. :P

cayennes commented 6 years ago

I've fixed it and uploaded the new version.