fix: check inner quad iterator for errors when closing

cayleygraph / cayley

An open-source graph database

https://cayley.io

Apache License 2.0

14.8k stars 1.25k forks source link

fix: check inner quad iterator for errors when closing #979

Closed paralin closed 2 months ago

paralin commented 1 year ago

This caused a bug where Scan returned an error which was ignored by the iterator. The inner iterator it.Err() would have returned the error correctly, but it was ignored in QuadIterator.

Fixed by checking the inner iterator error when closing.

This change is

paralin commented 1 year ago

@dennwc If you'd like, I'd be happy to take on the role of merging minor fixes & updating dependencies (maintenance) in Cayley's main repository. I have a more "destructive" fork which takes some more significant changes but would only apply minor fixes / improvements here.

paralin commented 12 months ago

@dennwc this was the bug that, coupled with the liberal use of context.TODO in the codebase, caused a few very hard to trace issues to occur some percentage of the time.