search

cazala / coin-hive

CoinHive cryptocurrency miner for node.js
https://www.npmjs.com/package/coin-hive
MIT License
1.99k stars 399 forks source link

Fix dev fees #89

Closed wmcmurray closed 6 years ago

wmcmurray commented 6 years ago

Fixes little details causing this tool to send 50% of all mining incomes to the developper...!! :unamused:

Here is some details about what I fixed :

  1. the devFeeThrottle variable existed but was never passed to the devFeeMiner !
  2. if a user set the devFees to 0 with the --dev-fee argument, it was ignored by the a || b syntax because zero equal false
  3. process.env.* variables type is string, not number, so I added some Number() where needed
evil7 commented 6 years ago

XD. Let's writeing down some bugs hahahah. Try es6 add a type for it. It's will better to debug

wmcmurray commented 6 years ago

Will there be an npm package version bump including this fix anytime soon ? :thinking: