Closed rzr closed 3 years ago
Latest version ok for @schnitzeltony ?
Hmm... still looks ugly to me but I don't want to block this - it builds without issues for me. Suggestion: Apply it as is and once I have some space cycles I'll send a follow up
is it just a question of style ? if yes I am flexible and I can align to your other recipes
I linted a bit the recipe and updated commit message to tell that packaging is aligned to Debian's one
But I am open to suggestions at
Related issue: https://github.com/adoptware/pinball/issues/9
To make it clear:
@cazfi Suggested this earlier: Take it as is and if somebody wants to rework it later - feel free. I did a build test before my previous comment and found no issues. Sorry but the decision remains upon you
ok I am fine with later improvements, please merge, then let me submit (in other PR) other tables recipes before touching those files
or do you prefer the extra tables in same PR ?
I hope to have time to look this next Thursday or Friday.
ok great ! I'll wait for you I am not hurry :)
I'm not very happy with the name of the recipe being just 'pinball', for the namespace reasons. It's not the only pinball game out there. However, seeing that it's its project name in sourceforge too, I think we can accept that.
In general my conclusion is that this is already, in its current form, an improvement to meta-games, so I'm about to merge this.
well I try to align the most to other distros it would be nice to not drift too much
Follow up to this change is: https://github.com/cazfi/meta-games/pull/53
Emilia Pinball libre pinball simulator for GNU/Linux
Bug: https://github.com/cazfi/meta-games/issues/51 Origin: https://github.com/CrossStream/meta-games/tree/sandbox/rzr/review/master Relate-to: https://purl.org/rzr/pinball Change-Id: Ibf66c90b8697e0e5322c35cadb298fbf3528458a Signed-off-by: Philippe Coval rzr@users.sf.net