cazitouni / QgisGLViewer

A simple streetview-like Qgis plugin for equirectangular image visualisation
GNU Affero General Public License v3.0
12 stars 2 forks source link

Issue with Gap value #3

Closed snorimaps closed 1 year ago

snorimaps commented 1 year ago

Hi

There seems to be an issue with Gap value calculation, Its way longer than intended (5m)...probably a CRS issue? I'm using CRS 4326.

image

Geopkg file: photos4.zip

snorimaps commented 1 year ago

I would also like to suggest the following features to make this more usable:

  1. Prev, Next buttons/arrows on the image viewer to move fwd or back through the image equence. An Image 'id' column could be used to maintain sequencing
  2. Ability to use mouse to click a location/point and for the image to open in the same image window without resetting the window position, zoom and view angle. Currently each time we need to select a different image for viewing, we would have to click on the plugins button in toolbar, select a point which would then open a new image window
cazitouni commented 1 year ago

Hello @snorimaps, Thanks for using my plugin and for your feedback. Indeed the issue could be related to the EPSG:4326 projection. Is it possible for you to send me a sample of your images with the associated geopackages for me to test it and fix the issue ? Otherwise ,you could try to reproject the points in 3857 it should wok as well.

For your suggestions : It's possible to move within the image by clicking on it in the right direction, the gap parameter will define the "jump" distance. But I could look to add buttons based on the ID it shouldn't be very difficult. For the second point, It could be a little more difficult to code But I could look into it as well.

Thanks again, for your feedback and suggestions.

snorimaps commented 1 year ago

Hi, Thanks for your very useful plugin!

Reg, the geopkg, I've attached the file to my original post at the bottom (zip file). The images are quite big,

The issue with navigating through the image is that due to the very high jump distance, when I click on the image it directly jumps to the very last image in the sequence, or even beyond that and says no image available. Clearly the issue is the Gap distance representation on map as you can see on the map image on my original post. For scale, the images are only about 3-5m apart.

I'm also attaching the images file folder here.

https://we.tl/t-JOuheCp5sH

Thank you!

cazitouni commented 1 year ago

Thanks for the sharing.

I've tried several modifications, the rubberband and the jump function should be good for 4326 now, even if the precision isn't very accurate with this projection. I've tried with your dataset but the direction seems a bit off. But I've also tried with some of mines and everything seems to works well.

Would you tried to install the extension with the attached zip and tell me if it works for you ?

Thank you in advance.

QgisGLViewer.zip

snorimaps commented 1 year ago

I've tested it with the zip version, the gap distance issue seems to have been resolved, thanks. image

Yes the direction/azimuth attributes seems to be off, in my data.

I think previous/next image buttons or click on map options would be great enhancements.

Thanks for your work!

cazitouni commented 1 year ago

Thanks you for your answer. I've commited the fixes to github and it will come on Qgis repo with version 1.3 in a few days. I will look forward to implement the buttons in a future version.

Do not hesitate to contact me again if you have any issues, I will close this one for now.

Kind regards, Clément.